Skip to content

Add python linuxfd to image and pmon - #3241

Closed
zzhiyuan wants to merge 1 commit into
sonic-net:masterfrom
zzhiyuan:linuxfd
Closed

Add python linuxfd to image and pmon#3241
zzhiyuan wants to merge 1 commit into
sonic-net:masterfrom
zzhiyuan:linuxfd

Conversation

@zzhiyuan

@zzhiyuan zzhiyuan commented Jul 30, 2019

Copy link
Copy Markdown
Contributor

- What I did
Add python linuxfd support in base image and pmon container.

To support a mix of blocking fd and polling event change detection in platform API, a timerfd is best suited to this task. Currently it would only be needed in base image but added for pmon as well since platform API functionality will most likely be used by pmon services in the future.

- How I did it

- How to verify it
linuxfd is able to be imported on device, and is able to be imported by python2 and python3 in pmon container.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lguohan

lguohan commented Jul 31, 2019

Copy link
Copy Markdown
Collaborator

this pr has increase the pmon docker size to 212MB.

docker-platform-monitor.gz | Jul 31, 2019 12:01:59 AM | 212.43 MB

current size is 126MB.

docker-platform-monitor.gz | Jul 31, 2019 5:05:24 AM | 126.72 MB

Can you fix this size issue?

lguohan
lguohan requested changes Jul 31, 2019
View reviewed changes

@lguohan lguohan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size increased a lot.

@zzhiyuan

zzhiyuan commented Aug 1, 2019

Copy link
Copy Markdown
Contributor Author

size increased a lot.

Just revised the commit, now the size increase is less than 100KB. Thanks.

@jleveque

jleveque commented Aug 2, 2019

Copy link
Copy Markdown
Contributor

You force-pushed, so we lost the history. Please try to avoid this if possible. What did you change in the new commit?

@zzhiyuan

zzhiyuan commented Aug 2, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

You force-pushed, so we lost the history. Please try to avoid this if possible. What did you change in the new commit?

Noted, will avoid force pushes in the future, here is what changed in this commit compared to the last one:
-Previous commit apt-get installs curl, gcc, python-dev, and python3-dev
-This commit only installs gcc and libpython-dev

-Previous commit installs up-to-date pip with curl
-This commit does not

-Previous commit installs linuxfd on python2 and python3
-This commit only installs linuxfd on python2, note that pmon doesn't have python3

-Previous commit apt-get purges curl and gcc
-This commit purges gcc and libpython-dev, note that curl was not installed

-This commit additionally cleans the apt lists folder.

Thanks

@zzhiyuan

zzhiyuan commented Aug 2, 2019

Copy link
Copy Markdown
Contributor Author

I will put this PR on hold until I have verified that the change is needed for platform API. Thanks.

@zzhiyuan zzhiyuan closed this Aug 2, 2019
mssonicbld added a commit that referenced this pull request Nov 27, 2024
@mssonicbld
[submodule] Update submodule sonic-swss to the latest HEAD automatica…
8f69124 
…lly (#20932)

#### Why I did it
src/sonic-swss
```
* 3da2e67 - (HEAD -> master, origin/master, origin/HEAD) [dualtor] Fix standby neighbor inconsistency after warm reboot (#3356) (2 hours ago) [Longxiang Lyu]
* 8bf38af - [Chassis][LAG_ID] Address the same lagid been used in two different LCs issue (#3303) (2 hours ago) [Marty Y. Lok]
* a9080f7 - Fixed narrowing conversion issues. (#3395) (2 hours ago) [mramezani95]
* 98303af - [fpmsyncd] support pipeline to flush with a timer (#3241) (2 hours ago) [Yijiao Qin]
* a8c358f - [Dash] Handle FC update for existing ENI objects (#3373) (6 hours ago) [Vivek]
```
#### How I did it
#### How to verify it
#### Description for the changelog
VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
@mssonicbld @VladimirKuk
[submodule] Update submodule sonic-swss to the latest HEAD automatica…
7055959 
…lly (sonic-net#20932)

#### Why I did it
src/sonic-swss
```
* 3da2e67 - (HEAD -> master, origin/master, origin/HEAD) [dualtor] Fix standby neighbor inconsistency after warm reboot (sonic-net#3356) (2 hours ago) [Longxiang Lyu]
* 8bf38af - [Chassis][LAG_ID] Address the same lagid been used in two different LCs issue (sonic-net#3303) (2 hours ago) [Marty Y. Lok]
* a9080f7 - Fixed narrowing conversion issues. (sonic-net#3395) (2 hours ago) [mramezani95]
* 98303af - [fpmsyncd] support pipeline to flush with a timer (sonic-net#3241) (2 hours ago) [Yijiao Qin]
* a8c358f - [Dash] Handle FC update for existing ENI objects (sonic-net#3373) (6 hours ago) [Vivek]
```
#### How I did it
#### How to verify it
#### Description for the changelog
roger530-ho pushed a commit to roger530-ho/sonic-buildimage that referenced this pull request Jun 23, 2026
@mssonicbld @roger530-ho
[submodule] Update submodule sonic-swss to the latest HEAD automatica…
89a109f 
…lly (sonic-net#20932)

#### Why I did it
src/sonic-swss
```
* 3da2e67 - (HEAD -> master, origin/master, origin/HEAD) [dualtor] Fix standby neighbor inconsistency after warm reboot (sonic-net#3356) (2 hours ago) [Longxiang Lyu]
* 8bf38af - [Chassis][LAG_ID] Address the same lagid been used in two different LCs issue (sonic-net#3303) (2 hours ago) [Marty Y. Lok]
* a9080f7 - Fixed narrowing conversion issues. (sonic-net#3395) (2 hours ago) [mramezani95]
* 98303af - [fpmsyncd] support pipeline to flush with a timer (sonic-net#3241) (2 hours ago) [Yijiao Qin]
* a8c358f - [Dash] Handle FC update for existing ENI objects (sonic-net#3373) (6 hours ago) [Vivek]
```
#### How I did it
#### How to verify it
#### Description for the changelog
xdqi pushed a commit to canonical/sonic-buildimage that referenced this pull request Jul 6, 2026
@mssonicbld
[submodule] Update submodule sonic-swss to the latest HEAD automatica…
63ac831 
…lly (sonic-net#20932)

#### Why I did it
src/sonic-swss
```
* 3da2e67 - (HEAD -> master, origin/master, origin/HEAD) [dualtor] Fix standby neighbor inconsistency after warm reboot (sonic-net#3356) (2 hours ago) [Longxiang Lyu]
* 8bf38af - [Chassis][LAG_ID] Address the same lagid been used in two different LCs issue (sonic-net#3303) (2 hours ago) [Marty Y. Lok]
* a9080f7 - Fixed narrowing conversion issues. (sonic-net#3395) (2 hours ago) [mramezani95]
* 98303af - [fpmsyncd] support pipeline to flush with a timer (sonic-net#3241) (2 hours ago) [Yijiao Qin]
* a8c358f - [Dash] Handle FC update for existing ENI objects (sonic-net#3373) (6 hours ago) [Vivek]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan lguohan requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zzhiyuan @lguohan @jleveque